feat(volo-http): add SSE client support with Accept header validation for server side#643
Open
Joshuahoky wants to merge 12 commits intocloudwego:mainfrom
Open
feat(volo-http): add SSE client support with Accept header validation for server side#643Joshuahoky wants to merge 12 commits intocloudwego:mainfrom
Joshuahoky wants to merge 12 commits intocloudwego:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 43.72% 44.61% +0.89%
==========================================
Files 161 162 +1
Lines 19679 20028 +349
==========================================
+ Hits 8604 8936 +332
- Misses 11075 11092 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SSE (Server-Sent Events) support was missing a client-side implementation for parsing SSE streams, and the server-side had no validation of the Accept header.
Solution
Added SseReader for parsing SSE streams from server responses
Added SseExt extension trait on Response for converting a response into an SseReader via into_sse()
Added ResponseExt trait with is_sse() for checking if a response has Content-Type: text/event-stream
Added Accept header validation in Endpoint::call
Added client and server examples demonstrating SSE usage